Fix channel name split issue in JPOS 3 #634
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JPOS 2, the channel name format is
{IP:port}
, but in JPOS 3, it changes to{LocalPort} {IP:Port}
(with a space between them). However, QServer splits the channel name based only on spaces, which causes unexpected behavior.Example:
Given the value of getISOChannelNames() returned by JPOS 3 is
10011 127.0.0.1:12345 10012 127.0.0.1:12346 10013 127.0.0.1:12346
Going thru the StringTokenizer, it will become this
channelName[0] = 10011
channelName[1] = 127.0.0.1:12345
channelName[2] = 10012
channelName[3] = 127.0.0.1:12346
Attached a photo during debugging
Fix the issue by providing a new regex.
Attach a photo of regrex checker
Add
!sb.isEmpty()
to the condition. Without it,getChannelNames()
will start with an empty space.